rpcpool / ping-thing-client

JS Client to Contribute Ping Times to the Validators.app Ping Thing
MIT License
0 stars 2 forks source link

Support for Jupiter Swap API #2

Closed WilfredAlmeida closed 6 months ago

WilfredAlmeida commented 6 months ago

Fixes #1

fanatid commented 6 months ago

lgtm

as Linus mentioned we need to refactor scripts and move duplicated code to shared file maybe it would be good to support args, like ping-thing.mjs --jup sol-usdc / ping-thing.mjs --transfer sol-sol

WilfredAlmeida commented 6 months ago

I'll refactor to abstract out the duplication and push.

maybe it would be good to support args, like ping-thing.mjs --jup sol-usdc / ping-thing.mjs --transfer sol-sol

A CLI-like approach can be taken to this, however, I'd like to know if its a priority. We need to assess the reliability of this and test & deploy it as well. So I'd prefer to focus on deployment & testing first and then implement this.