search

rpdasilva / print-html-element

Prints the HTML of a provided element.
MIT License
24 stars 10 forks source link

master #12

Closed konsultaner closed 8 years ago

konsultaner commented 8 years ago

make custom styles possible

rpdasilva commented 8 years ago

Thanks! Looks pretty good. Currently on vacation until the beginning of start of next week. Will give it a more thorough look then

konsultaner commented 8 years ago

thank you :) would be nice to see this feature, because angular-material adds some weired styles to the dom that make it impossible to print in portrait format.

rpdasilva commented 8 years ago

After looking through your PR, I think the feature is both valid and valuable. I do see some room for improvement however. For example, rather than having opts.styles doing double-duty for both inline styles and stylesheets, I think it makes sense to extend opts to also allow stylesheet overrides (something like opts.stylesheets).

I'd like to do some further work on top of what you've done. I'll merge this in and have a new release with this feature in the next day or two

konsultaner commented 8 years ago

Thank you!

rpdasilva commented 8 years ago

@konsultaner: New release should be up on npm print-html-element@0.5.1