rpdasilva / print-html-element

Prints the HTML of a provided element.
MIT License
24 stars 10 forks source link

fixed print & print priview issue for mobiles #15

Open sateeshkodati opened 8 years ago

sateeshkodati commented 8 years ago

1.fixed print & print priview issue for IOS 2.technically fix will work for any mobiles too.

rpdasilva commented 8 years ago

Hey @sateeshkodati - Thanks so much for this PR, I appreciate it. Sorry it took a while to get back to you, I've been away on vacation. It would be nice if the fix were as simple as window.print. It would help close #14.

Checking out your PR however, this doesn't appear to fix the print preview issue in iOS, at least on my iPhone (SE, iOS 10.0.1) and iPad (Mini 3, iOS 9.3.5) - tested in Mobile Safari - What's the iPhone/iOS version you're running (browser vs. uiwebview vs. wkwebview may also be relevant information here).

I can't confirm this does anything on Android, perhaps @zivester can try this out?

zivester commented 8 years ago

I can check this out tomorrow @rpdasilva , thanks for pointing this out to me.