Division by zero error if ply_count is zero

rpdelaney-archive / python-chess-annotator

Reads chess games in PGN format and adds annotations using an engine

GNU General Public License v3.0

62 stars 29 forks source link

Division by zero error if ply_count is zero #31

Open NajdorfB opened 5 years ago

NajdorfB commented 5 years ago

Fixes #30

When running the program, I sometimes ran into two different division by zero problems, caused by the fact that ply_count = 0. My solution is that the minimum of the division with ply_count is 1, so a division by zero is not possible. I suppose it would be better to ensure that ply_count never is zero, but I'm not sure how hard that is as I haven't really looked into the problem.

rpdelaney commented 5 years ago

Can you use the try / except syntax we discussed in #30 ?

rpdelaney commented 5 years ago

Now that I look at this I'm wondering if that just leads to divzero one level up in the stack. I'm also not sure how the old version of python-chess this is pinned to handles being told to analyze a position for 0 seconds. I'll test this more when I'm off work :)