rpdillon / todotxt.el

A todo.txt client for Emacs
55 stars 18 forks source link

Wrong todo is marked as done when cursor is at the beginning of a line and some todos are filtered out #15

Open minkkinen opened 7 years ago

minkkinen commented 7 years ago

As the title says, I sometimes find that the wrong todo is marked as done when cursor is at the beginning of a line and some todos are filtered out. I suspect that Emacs thinks that the cursor is actually on one of the hidden lines and marks that as done. This is potentially dangerous as it can be hard to hunt down which todo was just marked as done and then I forget to do something :)

I'm using GNU Emacs 25.1.1 and the latest todo.txt from MELPA.

fab-bar commented 7 years ago

In my fork I have committed a change that addresses this issue (3cb04f511d75a5a0bae19ef82c8af352842053e7): When point is on a hidden line no todo-item is marked as completed. Instead the user is warned that point is on a hidden line.

I think a proper fix of this issue would avoid the situation where point is on a hidden line but this simple modification avoids that todo-items are lost by marking a hidden item as completed.