search

rpeshkov / vscode-text-tables

VSCode extension that brings the power of Emacs table editing
MIT License
38 stars 14 forks source link

previousRow function is needed #37

Open mindgitrwx opened 6 years ago

mindgitrwx commented 6 years ago

First of all, thank you for having made this great extension.

I'm mapping this table generator with vscode's vim plugin, and I tried to map moving cell with h, j, k, l.

It seems not natural to exist nextRow function without previousRow function, ecpecially in this mapping. h, j, l key had been sucessfuly mapped with this extension, but k is not working well.

I checked this extension carefully, and I find there is no previousRow function.

Could you add this function for user experience?

rpeshkov commented 6 years ago

Hi @mindgitrwx,

There's now previousRow function mostly because it's quite useless. Going up 1 line will be mostly the same as previousRow. NextRow function exists mainly because when cursor is on the last row, new row will be inserted and that's not good case for previousRow since usually there's not so much use cases for adding new row in the top of table.

I'm not telling that I'm against that functionality, but for me that's definitely low priority. If you wish, you may create PR for that function. I'll gladly accept it to the codebase.