rpetit3 / dragonflye

:dragon: :fly: Assemble bacterial isolate genomes from Nanopore reads
GNU General Public License v3.0
117 stars 10 forks source link

Polypolish error #25

Closed andreagp96 closed 8 months ago

andreagp96 commented 9 months ago

Hi!

I'm trying to run dragonflye (v1.1.2) with default parameters using --reads, --R1 and --R2 inputs. The issue arises after assembling with flye, when dragonflye executes polypolish (v0.6.0): Running: polypolish flye/polish/racon/1/consensus.fasta flye/polish/short_reads/polypolish/1/polypolish_R1-1.sam flye/polish/short_reads/polypolish/1/polypolish-R2-1.sam > flye/polish/short_reads/polypolish/1/polypolish-1.fasta | sed 's/^/[short read polishing - polypolish (1 of 1)] /' | tee -a dragonflye.log

Error running command: polypolish flye/polish/racon/1/consensus.fasta flye/polish/short_reads/polypolish/1/polypolish_R1-1.sam flye/polish/short_reads/polypolish/1/polypolish-R2-1.sam > flye/polish/short_reads/polypolish/1/polypolish-1.fasta | sed 's/^/[short read polishing - polypolish (1 of 1)] /' | tee -a dragonflye.log

error: unrecognized subcommand 'flye/polish/racon/1/consensus.fasta'

I believe the issue is that the polish command is missing when calling polypolish.

Thanks for your hard work!

Andrea

rpetit3 commented 8 months ago

Hi @andreagp96, What operating system are you working on?

andreagp96 commented 8 months ago

Hello! I'm working on macOS (Ventura v13.6.4) :)

rpetit3 commented 8 months ago

Do you by chance have access to "Docker Desktop"?

andreagp96 commented 8 months ago

Mmm, I don't have access to "Docker Desktop". However, I was able to resolve the issue by modifying the dragonflye script using VIM. I added the command "polish" in line 414 as follows:

run_cmd("polypolish polish $POLISHED_FASTA $SAM_R1 $SAM_R2 > $round_dir/polypolish-$i.fasta", "short read polishing - polypolish ($i of $polypolish)");

instead of:

run_cmd("polypolish $POLISHED_FASTA $SAM_R1 $SAM_R2 > $round_dir/polypolish-$i.fasta", "short read polishing - polypolish ($i of $polypolish)");

Hoping this info is useful.

Kind regards,

Andrea

rpetit3 commented 8 months ago

This is super helpful! Thank you so much! I did not realize some changes in the most recent version of polypolish: https://github.com/rrwick/Polypolish/releases/tag/v0.6.0

I will update Dragonflye to pin the minimum version of polypolish to 0.6.0

andreagp96 commented 8 months ago

Happy to help!!

Thank you for your time and dedication,

Andrea