search

rpetit3 / dragonflye

:dragon: :fly: Assemble bacterial isolate genomes from Nanopore reads
GNU General Public License v3.0
117 stars 10 forks source link

Outdated read length after trimming adapters #8

Closed camilogarciabotero closed 2 years ago

camilogarciabotero commented 2 years ago

Hi @rpetit3,

Thanks for working on dragonflye it is an awesome pipeline! I found that there might be an outdated env variable that after trimming and quality filtering keeps sending the initial read length average.

https://github.com/rpetit3/dragonflye/blob/3757186157a8358db3032d2c1701cd2192697bbb/bin/dragonflye#L259

Cheers.

rpetit3 commented 2 years ago

Nice catch! I think I've addressed this here: https://github.com/rpetit3/dragonflye/commit/5d9098368656919198915a570b6643443c5c0c2e

Going to play around with it a bit to see.

Thanks for finding this!

camilogarciabotero commented 2 years ago

Hey!

Thank you for the quick response and potential solution!

rpetit3 commented 2 years ago

Thanks again for catching this.

I've released v1.0.10 (https://github.com/rpetit3/dragonflye/releases/tag/v1.0.10) with a fix.