search

rpgoldman / europa-pso

Automatically exported from code.google.com/p/europa-pso
0 stars 0 forks source link

String parameter becomes invalid after un-merging #159

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?

The planning problem in System/test/merge-with-open-domain.nddl exhibits the 
issue.

What is the expected output? What do you see instead?

Planning should complete.  Instead, when compiled in debug mode, the following 
checkError is hit:

ConstraintEngine/base/ConstrainedVariable.cc:529: Error: isValid() is false

as a result of relaxing the string parameter after un-merging.  The part of the 
isValid() check that is failing is the check to make sure that the last domain 
is a subset of the base domain.  The last domain has been re-opened, causing it 
to not be a subset of the base.

Original issue reported on code.google.com by miata...@gmail.com on 31 Oct 2012 at 10:56

GoogleCodeExporter commented 8 years ago 
I'm looking at this in the debugger. The problem seems to be originated in a 
piece of code in TokenVariable::handleReset that has been touched several times 
in the past, I'll have to spend some time making sure I get it right this time.

Mike, for the particular example that you provided, it looks like that 
assertion failure may be benign, I just need to make sure that the restricted 
base domain is reinstated before the split operation completes, are you seeing 
any problems when running optimized?

Original comment by javier.barreiro@gmail.com on 15 Nov 2012 at 1:30

GoogleCodeExporter commented 8 years ago 
I dug some more today. Looks like the following:

predicate Predicate { string parameter; parameter = "foo"; }

correctly closes the derived domain for "parameter" upon initialization for a 
master token, but it incorrectly leaves it open for a slave token, so there may 
be a bug in the europa runtime when dealing with the creation of slave tokens.

I have to take a break from this now but will follow this lead as soon as I get 
a chance.

Original comment by javier.barreiro@gmail.com on 16 Nov 2012 at 1:24

GoogleCodeExporter commented 8 years ago 
Mike, I've committed a fix for this, please verify and let me know if you still 
see any problems.

Original comment by javier.barreiro@gmail.com on 16 Nov 2012 at 7:54

GoogleCodeExporter commented 8 years ago

Original comment by javier.barreiro@gmail.com on 16 Nov 2012 at 7:54