search

rpgoldman / europa-pso

Automatically exported from code.google.com/p/europa-pso
0 stars 0 forks source link

Solver::noMoreFlaws() can lie, which seems unfari #4

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Load and initial state and use a solver to solve it.  Solver.hasFlaws()
correctly returns false.
2. Add something (for example, parse some new NDDL).
3. Solver.hasFlaws() INCORRECTLY return false.

The problem is that the solver has an internal variable m_noFlawsFound that
has no way of knowing that things have changed (so it becomes stale).

An obvious solution is to remove that variable, and force the code to
recheck every time hasFlaws() is called - ie call
allocateNewDecisionPoint().  However, this doesn't feel like a method that
should have side effects.  A discussion is currently under way on the
developers mailing list....

Original issue reported on code.google.com by tristanb...@gmail.com on 10 Aug 2009 at 10:27

GoogleCodeExporter commented 9 years ago

Original comment by javier.barreiro@gmail.com on 11 Aug 2009 at 12:10

GoogleCodeExporter commented 9 years ago

Original comment by javier.barreiro@gmail.com on 22 Nov 2010 at 10:29

GoogleCodeExporter commented 9 years ago

Original comment by javier.barreiro@gmail.com on 17 Aug 2011 at 8:30

GoogleCodeExporter commented 9 years ago

Original comment by javier.barreiro@gmail.com on 30 May 2012 at 5:26

GoogleCodeExporter commented 9 years ago 
Addressed in r6751 by adding a FlawManager::noMoreFlaws method and various 
implementations.

Original comment by miata...@gmail.com on 22 Sep 2014 at 6:31