search

rpgoldman / xmls

Simple, lightweight XML library for Common Lisp
Other
20 stars 5 forks source link

When there is no content to parse, return NIL from XMLS:PARSE. #15

Closed robert-dodier closed 1 year ago

robert-dodier commented 1 year ago

This is the behavior stated by README.html.

Define additional test cases for the new behavior.

This commit fixes https://github.com/rpgoldman/xmls/issues/14: "Working with empty document"

This commit implements the patch that is shown in issue #14.

rpgoldman commented 1 year ago

Hey Robert -- do you think you could rebase this on master? I think this branch is based off a state of the repo in which the tests are busted. Then we can merge if the tests all pass.

robert-dodier commented 1 year ago

Hi Robert, I'm not sure what you mean about rebasing. robert-dodier:master is just one commit ahead of rpgoldman:master -- robert-dodier:master~1 is rpgoldman:master.

I'll try it with different Lisps (I only tried SBCL so far). Are the tests successful with ECL, CMUCL, and CCL on rpgoldman:master?

rpgoldman commented 1 year ago

Thanks, Robert -- looks like something is wrong with roswell. I think it may be bit-rotted. I will check further and get back to you so we can get this merged.

robert-dodier commented 1 year ago

For the record, I tried (load "run-tests.lisp") with Clozure CL 1.12.2 on Linux x86-64 and it reports all tests passed.

rpgoldman commented 1 year ago

It seems like Roswell simply doesn't work right now, or at least the usage pattern has changed in a way that has broken this set of GitHub actions.

For other repositories, I have switched to using the cl foundation's docker images, but these are also unmaintained at the moment.

robert-dodier commented 1 year ago

Also, for the record, I tried the forked version with ECL 21.2.1 and all tests (36 tests) pass.

I know the problem seems to be Roswell, but anyway it seems like a good idea to establish that it works with various Lisps.

rpgoldman commented 1 year ago

I think I have the GitHub regression test actions almost fixed. When they are, I will merge them, and then ask you to rebase this so that the actions run, and will then merge, assuming all the tests pass (which I am confident they will).

Thanks for your patience!

rpgoldman commented 1 year ago

OK, please rebase on master and we should be good to go.

robert-dodier commented 1 year ago

Robert, I've rebased robert-dodier:master on rpgoldman:master. If I'm not mistaken, at this point you can merge the PR.

rpgoldman commented 1 year ago

OK, merged and I have bumped the version to 3.3 so that you can add (:version "xmls" "3.3") to ensure you get a version of the library with this new, backward-compatible, but not forward-compatible, capability.