rpgoldman / xmls

Simple, lightweight XML library for Common Lisp
Other
20 stars 5 forks source link

Tests failed for ECL implementation #3

Closed Hellseher closed 2 years ago

Hellseher commented 3 years ago

Hi,

While packing for Guix I noticed that test failed for ECL implementation.

phase `build' succeeded after 1.6 seconds starting phase `check'
Invoking ecl: "/gnu/store/pmg6fgkd59v8p52g186q3na0dx2bw3p1-ecl-21.2.1/bin/ecl"
"--eval" "(require :asdf)" "--eval" "(asdf:load-asd (truename
\"/gnu/store/97aiyiablqfph85bmkna350b4g7nchl1-ecl-xmls-3.0.2-1.18546f0/share/common-lisp/ecl/xmls/xmls.asd\"))"
"--eval" "(when (uiop:file-exists-p \"xmls-tests.asd\") (asdf:load-asd
(truename \"xmls-tests.asd\")))" "--eval" "(when (uiop:file-exists-p
\"xmls-test.asd\") (asdf:load-asd (truename \"xmls-test.asd\")))"
"--eval" "(when (uiop:file-exists-p \"tests.asd\") (asdf:load-asd
(truename \"tests.asd\")))" "--eval" "(when (uiop:file-exists-p
\"test.asd\") (asdf:load-asd (truename \"test.asd\")))" "--eval"
"(asdf:test-system \"xmls\")" "--eval" "(quit)" ;;; Loading
#P"/gnu/store/pmg6fgkd59v8p52g186q3na0dx2bw3p1-ecl-21.2.1/lib/ecl-21.2.1/asdf.fas"
An error occurred during initialization: There is no symbol :TEST in
package "XMLS". command
"/gnu/store/pmg6fgkd59v8p52g186q3na0dx2bw3p1-ecl-21.2.1/bin/ecl"
"--eval" "(require :asdf)" "--eval" "(asdf:load-asd (truename
\"/gnu/store/97aiyiablqfph85bmkna350b4g7nchl1-ecl-xmls-3.0.2-1.18546f0/share/common-lisp/ecl/xmls/xmls.asd\"))"
"--eval" "(when (uiop:file-exists-p \"xmls-tests.asd\") (asdf:load-asd
(truename \"xmls-tests.asd\")))" "--eval" "(when (uiop:file-exists-p
\"xmls-test.asd\") (asdf:load-asd (truename \"xmls-test.asd\")))"
"--eval" "(when (uiop:file-exists-p \"tests.asd\") (asdf:load-asd
(truename \"tests.asd\")))" "--eval" "(when (uiop:file-exists-p
\"test.asd\") (asdf:load-asd (truename \"test.asd\")))" "--eval"
"(asdf:test-system \"xmls\")" "--eval" "(quit)" failed with status 1
builder for `/gnu/store/ibfq58irvnmbl28xs2llg8d4bliqdr26-ecl-xmls-3.0.2-1.18546f0.drv'
failed with exit code 1 build of
/gnu/store/ibfq58irvnmbl28xs2llg8d4bliqdr26-ecl-xmls-3.0.2-1.18546f0.drv
failed View build log at
'/var/log/guix/drvs/ib/fq58irvnmbl28xs2llg8d4bliqdr26-ecl-xmls-3.0.2-1.18546f0.drv.bz2'.
cannot build derivation
rpgoldman commented 3 years ago

The reason that is happening is that the test is wrapped in

#+(or sbcl cmu allegro abcl ccl clisp)

...and the reason I did that was that I didn't know how command line arguments work in ECL, and test accepts command-line arguments.

I tweaked it so that it (sort of) works, and the tests pass on ECL, so you can use XMLS with reasonable confidence.

rpgoldman commented 2 years ago

Fixed by #8