rpgtkoolmv / corescript

http://www.rpgmakerweb.com/products/programs/rpg-maker-mv
MIT License
311 stars 75 forks source link

Map and Battle scenes drawing delay of official corescript ver1.6.1 #180

Closed rev2nym closed 5 years ago

rev2nym commented 5 years ago

In official corescript ver1.6.1, Drawing map and battle scenes is delay at scene starting. Background image is drawn first, and tile images are drawn after it. The cause is to begin drawing by Spriteset_Base before finishing loading image files.

It's possible to check by following way. It's also possible to test on a Community edition corescript.

Apply this code and run as test. It will display "false" at first calling.

var _Spriteset_Base_update =
    Spriteset_Base.prototype.update;
Spriteset_Base.prototype.update = function() {

    console.log(ImageManager.isReady());

    _Spriteset_Base_update.call(this);
};

And try following code. This causes a stack overflow in map scene.

var _Spriteset_Base_update =
    Spriteset_Base.prototype.update;
Spriteset_Base.prototype.update = function() {

    console.log(SceneManager._scene.isReady());

    _Spriteset_Base_update.call(this);
};

These mean that sprites have begun to draw though images aren't ready.

krmbn0576 commented 5 years ago

Close this because it is solved by #194