search

rpgtkoolmv / corescript

http://www.rpgmakerweb.com/products/programs/rpg-maker-mv
MIT License
311 stars 74 forks source link

fix null reference and shows entire frame bug. #20

Closed ghost closed 7 years ago

ghost commented 7 years ago

This fix bug wrote in Title.

krmbn0576 commented 7 years ago

I found a description similar to TillingSprite#bitmap(set). Would you like to change it the same way?

ghost commented 7 years ago

TilingSprite is already guarded by line: 183 I think this is enough.

krmbn0576 commented 7 years ago

OH, really? If so, why not Sprite as well?? It's one-line!

ghost commented 7 years ago

Sprite needs clearing frame, This can cause showing entire frame. so I defer clearing frame until Bitmap will load.

krmbn0576 commented 7 years ago

Hmm, I still don't understand your intentions. What situations do you want to avoid?

In this code, frame is refreshed when bitmap changes null to non-null. frame is never changed when bitmap changes non-null to anything. Is this behavior correct?

ghost commented 7 years ago

I deferred only clearing entire frame. updating frame is done by _refresh