Review PAST changes before proceeding

rpgtkoolmv / corescript

MIT License

311 stars 74 forks source link

Closed krmbn0576 closed 7 years ago

krmbn0576 commented 7 years ago

This core script has already been largely changed from the original core script. So, we should review these changes first and foremost.

Suggestion: Re-push the original core script and send PR of past changes

hajimehoshi commented 7 years ago

How about creating a branch and doing that there?

ghost commented 7 years ago

I agree with Hoshi's suggestion. But, I worked before decision to use github-flow, so many changes merged.

Review Process I prefer is:

krmbn0576 commented 7 years ago

Sounds good ;-)

ghost commented 7 years ago

ghost commented 7 years ago

The repository is renewed by original layout. and I make PR individually.