search

rpgtkoolmv / corescript

http://www.rpgmakerweb.com/products/programs/rpg-maker-mv
MIT License
311 stars 74 forks source link

needs review #9

Closed ghost closed 7 years ago

ghost commented 7 years ago

There are a lot of changes.

any questions are welcome!!

hajimehoshi commented 7 years ago

I'd split this into some PRs to make it easier to review.

krmbn0576 commented 7 years ago

I have not seen it in detail yet, but I have some questions.

ghost commented 7 years ago

@hajimehoshi Hmm, how? I have no idea to do this.

@krmbn0576

Why is "CSS Font Loading" necessary? Is not the current font loading insufficient?

Old algorithm cannot handle errors, and force failing if loading takes over 20 sec. This may occur under poor connection.

"Fix memory bloat" and "background preload" are very huge changes, so I would like a brief explanation.

I'll write it later (heavy work for me ; v ;)

hajimehoshi commented 7 years ago

Hmm, how? I have no idea to do this.

Just make multiple PRs for individual changes. Is this hard?

ghost commented 7 years ago

Discard this branch? I see. I'll try.

hajimehoshi commented 7 years ago

Yeah, IMHO this PR is too big to review...