rpherbig / dr-scripts

A series of Lich 5 (https://github.com/elanthia-online/lich-5) scripts for use with DragonRealms (http://www.play.net/dr/). Donations are welcome (http://www.paypal.me/rcuhljr)!
GNU General Public License v2.0
52 stars 177 forks source link

Arrows // lodged items left behind on exit from combat-trainer if 3rd party kills non-engaged. #1549

Closed brycole closed 2 years ago

brycole commented 7 years ago

Heyo,

So this little bug has been creeping around for a long time and have finally been able to get definitive logs of it happening.

Once combat-trainer exits, it waits for 1 mob to death to ensure lodged items/arrows are recovered. However, if any third party kills a monster, that counts as the mob death and combat-trainer exits.

This can be any AOE spell or construct, etc. e.g. USOL, dirt constructs, zombies, fire ball, etc etc.

See logs below. Shot arrow, construct gets kill on primary engagement, combat script exits.

> [combat-trainer]>shoot
> You feel fully prepared to cast your spell.
> You think you have your best shot possible now.
> The blue-dappled prereni teeters and nearly falls over.
> * Apparently without direction or thought, a blue-dappled prereni kicks out its hooves at you.  You evade, twisting easily away from the blow.  
> [You're adeptly balanced and in dominating position.]
> Your attempt is slightly hindered by your diamond-hide shield.
**_> < Driving in with an overwhelming assault, you fire a razor-edged arrow at a blue-dappled prereni.  A blue-dappled prereni fails to evade, avoiding only some of the blow.  The arrow lands a hard hit to the prereni's abdomen.
> The razor-edged arrow lodges itself shallowly into the blue-dappled prereni!_**
> [You're adeptly balanced and overwhelming opponent.]
> [Roundtime 1 sec.]
> [combat-trainer]>cast
> You gesture at a blue-dappled prereni.
> The blue-dappled prereni bleats in anger as you cast at it!
> You whisper several words of arcane power, attempting to twist a blue-dappled prereni's mind with primal terror.
> Your malefic assault overtakes a blue-dappled prereni, petrifying him to the spot!
> Roundtime: 2 sec.

> You feel fully rested.
> You feel fully attuned to the mana streams again.
> * In a weak and directionless display of aggression, a blue-dappled prereni rears back into the air, kicking its front legs, and stamps at you.  You partially block with a diamond-hide shield edged with a tyrium band.  
> [You're adeptly balanced and in dominating position.]
> * Awkwardly, a blue-dappled prereni kicks out its hooves at you.  You partially block with a diamond-hide shield edged with a tyrium band.  
> [You're adeptly balanced and in superior position.]
> Moving with the precision of a mongoose, a broad dirt construct pounds a large stone fist at a blue-dappled prereni.  A blue-dappled prereni attempts to dodge, only partially avoiding the impact.  The fist lands a strong hit that thumps painfully on the toes of the left foot!  
> [combat-trainer]>load
> Your diamond-hide shield makes the task more difficult.
> You reach into your pack to load the battle shortbow with a razor-edged arrow.
> Roundtime 5 sec.
> * Ineptly, a blue-dappled prereni slices wide at you.  You dodge, leaning to one side.  
> [You're adeptly balanced and in dominating position.]
> The blue-dappled prereni twitches as if trying to shake off its afflictions.
> * As if fumbling muscle flab were natural, a blue-dappled prereni rears back into the air, kicking its front legs, and stamps at you.  You partially block with a diamond-hide shield edged with a tyrium band.  
> [You're nimbly balanced and in superior position.]
> * Moving in like a timid schoolboy, a blue-dappled prereni kicks out its hooves at you.  You dodge, stepping out of harm's way.  
> [You're nimbly balanced and in better position.]
> Driving in with an overwhelming assault, a broad dirt construct swipes a large stone fist at a blue-dappled prereni.  A blue-dappled prereni fails to evade, avoiding only some of the blow.  The fist lands an extremely heavy hit that breaks the right femur with a sickening crunch of splintered bone, stunning him!  
> The blue-dappled prereni falls to the ground, its legs crumpling underneath it.
> [combat-trainer]>aim
> You begin to target a blue-dappled prereni.
> [combat-trainer]>bob
> You bob suddenly, lowering yourself into a smaller target.
> [You're adeptly balanced and overwhelming opponent.]
> Roundtime: 3 sec.
> * Tentatively, a blue-dappled prereni kicks out its hooves at you.  You evade, moving out of the way.  
> [You're adeptly balanced and in excellent position.]
> [combat-trainer]>bob
> You bob suddenly, lowering yourself into a smaller target.
> [You're adeptly balanced and overwhelming opponent.]
> Roundtime: 4 sec.
> A blue-dappled prereni bounds lightly into view.
> The blue-dappled prereni blinks slowly, its large eyes rather glassy.
> * With pathetic timing, a blue-dappled prereni kicks out its hooves at you.  You partially block with a diamond-hide shield edged with a tyrium band.  
> [You're adeptly balanced and in superior position.]
**_> Driving in with exacting precision, a broad dirt construct slams down at a blue-dappled prereni.  A blue-dappled prereni attempts to dodge, mis-stepping and blundering into the blow.  The foot lands an awesome strike that knocks the larynx clear back to the vertebrae (So much for last words!)!  
> The blue-dappled prereni falls to the ground, letting out an angry bleating sound while kicking at empty air with its hooves.  Raising its head one last time as if in defiance, the prereni softly exhales its final breath._**
> The blue-dappled prereni twitches as if trying to shake off its afflictions.
> [combat-trainer]>arrange all for skin
> * In a weak and directionless display of aggression, a blue-dappled prereni rears back into the air, kicking its front legs, and stamps at you.  You evade, moving cleanly out of the way.  
> [You're adeptly balanced and in dominating position.]
> You complete arranging the prereni's corpse in a manner that, while making the process of obtaining a skin more difficult, guarantees a greater reward.
> Roundtime: 5 sec.
> You think you have your best shot possible now.
> The blue-dappled prereni no longer seems petrified.
> * Apparently without direction or thought, a blue-dappled prereni kicks out its hooves at you.  You block with a diamond-hide shield edged with a tyrium band.  
> [You're adeptly balanced and in excellent position.]
> The dirt construct begins to advance on a blue-dappled prereni.
> [combat-trainer]>perform preserve on prereni
> You bend over the prereni's corpse to make one long, continuous cut with your ritual knife that just barely pierces into it.  Unseen energies seep into the creature's fluids, suspending the corpse in unnatural stasis for a time.
> Roundtime: 4 sec.
> You've gained a new rank in using melee weapons.
> * Ineptly, a blue-dappled prereni slams down at you.  You dodge, twisting easily away from the blow.  
> [You're nimbly balanced and in dominating position.]
> The blue-dappled prereni begins to advance on a broad dirt construct.
> * Tentatively, a blue-dappled prereni bares its large teeth and bites at you.  You evade, jumping to one side.  
> [You're nimbly balanced and in strong position.]
> The dirt construct closes to pole weapon range on a blue-dappled prereni.
> The dirt construct stops a blue-dappled prereni from advancing any farther.
> * As if fumbling muscle flab were natural, a blue-dappled prereni kicks out its hooves at you.  You block with a diamond-hide shield edged with a tyrium band.  
> [You're nimbly balanced and in very strong position.]
> [combat-trainer]>skin
> Moving with impressive skill and grace, you effortlessly retrieve a perfect skin from the blue-dappled prereni.
> You carefully fit a prereni skin into your bundle.
> Roundtime: 2 sec.
> [combat-trainer]>loot goods
> You search the blue-dappled prereni.
> You find nothing of interest.
> [combat-trainer]>pre pv 1
> You trace a careful sigil in the air, shaping the pattern of the Petrifying Visions spell.
> The dirt construct closes to melee range on a blue-dappled prereni.
> The blue-dappled prereni chews on a bit of grass, appearing rather unconcerned.
> A cougar slinks into the room, grabs the corpse of a blue-dappled prereni by the neck and drags it off into the brush.
> * Tentatively, a blue-dappled prereni slices wide at you.  You dodge, jumping to one side with little effort.  
> [You're nimbly balanced and in dominating position.]
> * Ineptly, a blue-dappled prereni slices wide at you.  You evade, twisting to one side.  
> [You're nimbly balanced and in superior position.]
> Trying inexpertly, a blue-dappled prereni rears back into the air, kicking its front legs, and stamps at a broad dirt construct.  A broad dirt construct dodges, just managing to get out of a tight spot.  
> * As if effort and skill were a bad thing, a blue-dappled prereni kicks out its hooves at you.  You block with a diamond-hide shield edged with a tyrium band.  
> [You're nimbly balanced and in dominating position.]
> The blue-dappled prereni paws its hoof at the ground, distracted at a nearby noise.
> You feel fully prepared to cast your spell.
> [combat-trainer]>cast
> You gesture at a blue-dappled prereni.
> The blue-dappled prereni bleats in anger as you cast at it!
> You whisper several words of arcane power, attempting to twist a blue-dappled prereni's mind with primal terror.
> Your malefic assault overtakes a blue-dappled prereni, petrifying him to the spot!
> You feel fully attuned to the mana streams again.
> [combat-trainer]>retreat
> The air around you solidifies into a twinkling yellow glow and intercepts the attack with a shower of coruscating light.
> * Moving well, a blue-dappled prereni bares its large teeth and bites at you.  You barely fail to block with diamond-hide shield.  The bite lands an ineffective strike to your right arm.
> [You're nimbly balanced and in strong position.]
> Moving inexpertly, a blue-dappled prereni kicks out its hooves at a broad dirt construct.  A broad dirt construct evades, barely stepping to one side.  
> * With pathetic timing, a blue-dappled prereni bares its large teeth and bites at you.  You block with a diamond-hide shield edged with a tyrium band.  
> [You're nimbly balanced and in very strong position.]
> You retreat back to pole range.
> [combat-trainer]>retreat
> You retreat from combat.
> [combat-trainer]>stow my battle.shortbow
> You easily strap your battle shortbow to a shimmering faeweave baldric with cambrinth buckles.
> --- Lich: combat-trainer has exited.
> [hunting-buddy]>retreat
izawwlgood commented 7 years ago

Worth pointing out that the easiest solution is to simply train missile stuff separately from TM and/or pets.

brycole commented 7 years ago

Yeah, I can confirm that moving my bow to a different YAML then pets/AOE has helped. However, this also impacts group hunting since a player can kill a mob and trigger the same results. This gives it a bit higher priority in my mind.

A couple options that we were tossing about on DRPrime might be...

  1. Always using a weapon which results in "[You're solidly balanced]" when you kill the enemy you are engaged to.
  2. Using a look on all creatures to determine if any lodged items are present. (Could use downhookstream to keep this clean.)
  3. Keeping counts of lodged items and whether they have been looted.

As a side note... a change that would be useful across multiple scripts. An option to determine what skill/spell to use when "finishing off" the enemy. So if you were using TM only but set your finishing to 2HE, (because maybe its strong) could help address the ammo issue and add extra functionality.

MahtraDR commented 2 years ago

Whilst I agree this is an issue, and I think it's even around today... we can't (and won't) code for all edge cases. In this instance, one wouldn't be stuck if they set skip_last_kill which is the recommended way today.