rpherbig / dr-scripts

A series of Lich 5 (https://github.com/elanthia-online/lich-5) scripts for use with DragonRealms (http://www.play.net/dr/). Donations are welcome (http://www.paypal.me/rcuhljr)!
GNU General Public License v2.0
53 stars 177 forks source link

Arranging & Skinning in combat-trainer #3544

Closed Kaesken closed 5 years ago

Kaesken commented 5 years ago

The combat-trainer script keeps wanting to do "arrange all for [type]" or just "skin" by itself.

That doesn't work. It needs to be "arrange dead for type" or "skin dead" else you get "You don't know how to do that." and "Skin what?".

Sarvatt commented 5 years ago

it works fine and has for years, figuring out why arrange all isn't working for you with the DR parser is the problem. Does your name start with all or was someone named all in the room?

Sarvatt commented 5 years ago

I use an allarh which does interfere with loot all but its never interfered with arranging

Sarvatt commented 5 years ago

the problem is more likely you turned on arrange all but you don't have the crafting technique to do it?

Kaesken commented 5 years ago

Nobody is in the room with me and my name does not start with all, no. There's a crafting technique? I ended up just going into the combat-trainer script and changing it to "dead" instead. I'll have to look into the technique. I typically don't bother with the crafting system nor the techniques.

Sarvatt commented 5 years ago

you have arrange_all: true set in your skinning: section in your yaml forcing it to arrange all

Sarvatt commented 5 years ago

https://elanthipedia.play.net/Arrange_command

Sarvatt commented 5 years ago

arrange all does 5 arranges in one command

Kaesken commented 5 years ago

I can arrange all, no problem, but it has to be worded "arrange dead all". But I'll definitely look into those techniques, thank you. :)

Sarvatt commented 5 years ago

noone else has that problem so yeah look into why you hit it :) most likely the DR parser is just chopping off all from your command there and you aren't doing it.

Kaesken commented 5 years ago

Hah, well I ended up just opening the combat-trainer script and just editing it myself on my end, lol So now it's working. Still learning of all this! It's definitely very interesting. Imma close this since it's been solved. Again, thank you!

Kaesken commented 5 years ago

Just so you know, I did try to go get the crafting technique as mentioned above but it's not offered to me due to lack of skill. Is there any way to disable the built-in scripts from auto-updating? I tried to disable it in the repository settings but I still have to extract my edited 'combat-manager' because every time I log in, Lich edits it back to the original file.

jandersson commented 5 years ago

There's not much we can do based on the information youve given.

jandersson commented 5 years ago

Can you post a link to a log of when it happens? and a link to your config/yaml file? That would help tremendously

Kaesken commented 5 years ago

Well "skin" by itself is now working rather than asking me "Skin what?" all the time. "arrange all for all" gives me this: "You don't know how to do that." Which I understand to go get a technique to be able to use that, HOWEVER, without the technique, I can type "arrange DEAD for all" and it'll arrange it without the technique which is what I'm not getting some folks to understand.

I don't believe it's a yaml issue at all.

Kaesken commented 5 years ago

So maybe set combat-trainer to check your outfitting skill and if you're below 25 ranks, use "arrange DEAD for all" but if you're above 25 ranks, use the "arrange ALL for all"?

Sarvatt commented 5 years ago

you arent doing an arrange all unless you have the techniques, just arrange all off in your yaml until you get the 50 engineering or outfitting to learn arrange all and set arrange_count higher than 1...

On Tue, May 14, 2019 at 7:25 PM Kaesken notifications@github.com wrote:

Well "skin" by itself is now working rather than asking me "Skin what?" all the time. "arrange all for all" gives me this: "You don't know how to do that." Which I understand to go get a technique to be able to use that, HOWEVER, without the technique, I can type "arrange DEAD for all" and it'll arrange it without the technique which is what I'm not getting some folks to understand.

I don't believe it's a yaml issue at all.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/rpherbig/dr-scripts/issues/3544?email_source=notifications&email_token=AA7CDRNKTVNNSBPL7N66NVLPVNC6RA5CNFSM4HJZXQNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVNCJOY#issuecomment-492446907, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7CDRNEBY7ED25EOAXH7YDPVNC6RANCNFSM4HJZXQNA .

Sarvatt commented 5 years ago

you’re juat doing the standard 1 arrange

On Tue, May 14, 2019 at 7:26 PM Kaesken notifications@github.com wrote:

So maybe set combat-trainer to check your outfitting skill and if you're below 25 ranks, use "arrange DEAD for all" but if you're above 25 ranks, use the "arrange ALL for all"?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/rpherbig/dr-scripts/issues/3544?email_source=notifications&email_token=AA7CDRKB76WRNCI5HCCA6RTPVNDBPA5CNFSM4HJZXQNKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVNCKQI#issuecomment-492447041, or mute the thread https://github.com/notifications/unsubscribe-auth/AA7CDRMEK7ZWVJY24GV6SR3PVNDBPANCNFSM4HJZXQNA .

Kaesken commented 5 years ago
  Outfitting:      3 98.75% clear          (0/34)

Therefore, I don't have the ability to get the technique.

arrange all for all You don't know how to do that. arrange dead for all Are you trying to arrange for a skin, part or bone? arrange dead all

You begin to arrange the serpent's corpse in a manner that, while making the process of obtaining a part more difficult, guarantees a greater reward. Roundtime: 2 sec. arrange dead all

You continue arranging the serpent's corpse in a manner that, while making the process of obtaining a part more difficult, guarantees a greater reward. Roundtime: 2 sec.

arrange dead all

You continue arranging the serpent's corpse in a manner that, while making the process of obtaining a part more difficult, guarantees a greater reward. Roundtime: 2 sec.

arrange dead all

You continue arranging the serpent's corpse in a manner that, while making the process of obtaining a part more difficult, guarantees a greater reward. Roundtime: 2 sec. R> arrange dead all

You complete arranging the serpent's corpse in a manner that, while making the process of obtaining a part more difficult, guarantees a greater reward. Roundtime: 2 sec.

skin

Moving with impressive skill and grace, you effortlessly retrieve a perfect fang from the Endrus serpent. You carefully fit a jagged wooden fang into your bundle. Roundtime: 2 sec.

Kaesken commented 5 years ago

Explain that then?

Tarhish commented 5 years ago

So here it is in combat-trainer:

@arrange_all = skinning['arrange_all'] || false
arrange_message = @arrange_all ? "arrange all for #{type}" : "arrange for #{type}"

In other words, the only reason it'd do ARRANGE ALL FOR WHATEVER is if you have skinning set to arrange_all in your yaml. It doesn't do that unless you tell it to.

Similarly, this:

skinning:
  skin: true
  arrange_all: false
  arrange_count: 0
  tie_bundle: false

is the default. I'd advise searching your yaml for a skinning setting

Sarvatt commented 5 years ago

arrange all has a higher RT than a normal arrange which is the part you are not getting, it combines 4 arranges into one arrange action with lesser RT

arrange all You complete arranging the wyvern's corpse in a manner that, while making the process of obtaining a part more difficult, guarantees a greater reward. Roundtime: 5 sec.

Sarvatt commented 5 years ago

arrange dead for all is doing nothing but a normal arrange because the dragonrealms game parser is just reducing it to "arrange"

Kaesken commented 5 years ago

So if I put 'arrange: false' it'll do "arrange dead all" instead for the script or not do arrange at all? Because I DO want to arrange. I just CANNOT with the phrase "arrange all for all" it HAS to be "arrange DEAD all"

Sarvatt commented 5 years ago

skinning:
  skin: true
  arrange_all: false
  arrange_count: 1 (or up to 4)
  tie_bundle: false
Sarvatt commented 5 years ago

that will just arrange 1 time, or however many you set in arrange_count:, arrange all does all of the possible arrange actions in one action so you dont have to do the 2 second arranges multiple times to learn more

Kaesken commented 5 years ago

Ok, thank you! I thought "arrange_all" was just asking me if I wanted to do that. I didn't know that it was attached to the technique. I get it now. Thanks, Sarvatt.

Sarvatt commented 5 years ago

no worries, its worth getting that technique though for massively increased learning though! 50 outfitting or engineering to get a technique slot isnt more than a few days throwing a craft outfitting in a before or something. you only need knitting needles. the bone and skin ones both let you arrange all anything.