rpherbig / dr-scripts

A series of Lich 5 (https://github.com/elanthia-online/lich-5) scripts for use with DragonRealms (http://www.play.net/dr/). Donations are welcome (http://www.paypal.me/rcuhljr)!
GNU General Public License v2.0
52 stars 177 forks source link

[script] [combat-trainer.lic] - Ranged attacks do not increment action_taken #5202

Closed asechrest closed 2 years ago

asechrest commented 2 years ago

The script does not appear to increment the action_taken value when firing for ranged combat. I'll attach a brief log. Longer log available.

You remain concealed by your surroundings, convinced that your moving to fire went unobserved.
< You snipe a small rock at a dire bear.  A dire bear fails to dodge.  The rock lands a good strike to the bear's back.
The small rock lodges itself shallowly into the dire bear!
[You're nimbly balanced and in dominating position.]
[Roundtime 1 sec.]
[combat-trainer: Stowing ammo: rock, 1]
[combat-trainer]>stow my rock
You come out of hiding.
Stow what?  Type 'STOW HELP' for details.
[combat-trainer: action count: 0 vs 10]
[combat-trainer: skill exp: 4 vs 3]
[combat-trainer: new skill needed for training]
[combat-trainer: checking weapons as "Slings"!=Light Thrown]

Because it does not increment this value, the script does not honor the combat_trainer_action_count: setting in associated yamls when using a ranged weapon. Tested so far with a bow and a sling.

A review of the section of code dedicated to ranged combat seems to indicate that action_taken isn't incremented except in the section that detects when firing at corporeal without Bless. I'm currently testing a one-line fix locally.

log.md

asechrest commented 2 years ago

Hashed this out last night on Discord. It's a regex issue. I'll have a PR this evening.

asechrest commented 2 years ago

Closed via #5204