search

rpi-ws281x / rpi-ws281x-python

Python library wrapping for the rpi-ws281x library
BSD 2-Clause "Simplified" License
326 stars 103 forks source link

Fixes cross compile building with Buildroot #23

Closed ninioperdido closed 4 years ago

ninioperdido commented 5 years ago

Hi!

I had a hard time trying to build this library using the standard Buildroot "python-package". The library always ended built for the Host triplet instead of the Target. This setup.py modification avoid the use of the Makefile, building the ws281x library using the setup.py. This way the library is cross compiled correctly in Buidlroot, as well as, using the usual "python setup.py build".

Let me know your thoughts.

Gerardo.

sommersoft commented 5 years ago

I was experiencing the same as #26. Just wanted to report that this fixes build issues for me. On a Raspberry Pi 3B+, running Ubuntu Server 19.04.

~$ uname -a
Linux rosiepi 5.0.0-1020-raspi2 #20-Ubuntu SMP Wed Oct 2 07:03:12 UTC 2019 aarch64 aarch64 aarch64 GNU/Linux
~$ cat /etc/debian_version
buster/sid
~$ cat /proc/device-tree/model
Raspberry Pi 3 Model B Plus Rev 1.3
~/rpi_ws281x$ git clone https://github.com/rpi-ws281x/rpi-ws281x-python.git
~/rpi_ws281x$ cd rpi-ws281x-python
~/rpi_ws281x/rpi-ws281x-python$ git submodule update --init --recursive
(venv) ~/rpi_ws281x/rpi-ws281x-python$ git fetch origin pull/23/head:ninioperdido
(venv) ~/rpi_ws281x/rpi-ws281x-python$ git checkout ninioperdido
(venv) ~/rpi_ws281x/rpi-ws281x-python/library$ pip3 install -e .                      
Obtaining file:///home/rpi_ws281x/rpi-ws281x-python/library
Installing collected packages: rpi-ws281x
  Running setup.py develop for rpi-ws281x
Successfully installed rpi-ws281x
Gadgetoid commented 4 years ago

Sorry this library has been totally off my radar for a number of months (a large number, it seems). This is a far better approach than the Makefile inclusion, thank you for taking the time to raise it as a PR!