search

rpip / paystack-go

Go library for the Paystack API https://developers.paystack.co/v1.0/reference
MIT License
62 stars 39 forks source link

changed bvn match logic to match Paystack's current bvn match endpoint #14

Closed sayopaul closed 1 year ago

sayopaul commented 1 year ago

The previously implemented ResolveBVN() method was returning the message message:BVN Service Unavailable status:false due to Paystack changing their BVN functionality and endpoint totally. This pull request updates the library to use Paystack's recent BVN match endpoint as seen here https://paystack.com/docs/identity-verification/verify-bvn-match/. I also updated the tests.

sayopaul commented 1 year ago

@Obayanju hello 👋 . Any chance that this could be reviewed soon ?

Obayanju commented 1 year ago

acknowledged

Obayanju commented 1 year ago

Currently updating the CI so we can run tests. Also fixing some tests that are currently failing. Will update you ASAP. Thanks :)

sayopaul commented 1 year ago

@Obayanju any update on this?

sayopaul commented 1 year ago

Closing this PR as I eventually decided to use my updated fork in my project. I changed the go.mod so merging this would break stuff.