search

rpip / paystack-go

Go library for the Paystack API https://developers.paystack.co/v1.0/reference
MIT License
63 stars 42 forks source link

add go mod #3

Closed kayslay closed 5 years ago

kayslay commented 5 years ago

add go mod file after facing a bug in go v1.11

rpip commented 5 years ago

thanks @kayslay. Could you share more on the bug in go v1.11 that prompted this fix?

kayslay commented 5 years ago

when installing/updating the package returns $ go get -u

...
# github.com/rpip/paystack-go
../../../../pkg/mod/github.com/rpip/paystack-go@v0.0.0-20180509111153-5333b023a74e/bank.go:3:8: can't find import: "fmt"

since the package failed to install completely, when building it returns this error

../../../../pkg/mod/github.com/rpip/paystack-go@v0.0.0-20180509111153-5333b023a74e/plan_test.go:1:1: expected 'package', found 'EOF'
makefile:2: recipe for target 'run' failed
make: *** [run] Error 1
rpip commented 5 years ago

Understood. What's the difference between this PR #3 and the other opened PR #4?

Also, can you update the Travis script to ensure this module support build works? E.g:

script:
  - env GO111MODULE=on go build 
  - env GO111MODULE=on go test
rpip commented 5 years ago

hi @kayslay, please help here: what's the difference between this PR #3 and the other opened PR #4?

kayslay commented 5 years ago

I made a mistake in PR #3. I was trying to merge from my forked master branch. PR #4 merges from the kayslay:rpip-module-name

rpip commented 5 years ago

So this #4 PR is where the fix is? Will review.

Thanks

rpip commented 5 years ago

closing this #3 PR now.

kayslay commented 5 years ago

Yes

On Nov 9, 2018 16:16, "Yao Adzaku" notifications@github.com wrote:

So this #4 https://github.com/rpip/paystack-go/pull/4 PR is where the fix is? Will review.

Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/rpip/paystack-go/pull/3#issuecomment-437390318, or mute the thread https://github.com/notifications/unsubscribe-auth/AItVJclj5OkaiSYGrvQyMwMZV-Q03tPUks5utZxbgaJpZM4YPDa8 .