Interactive list - Githubissues

rpire / to-do-list

This is a project for the second week from module: #2 of the Microverse Program

5 stars 0 forks source link

Interactive list #3

Closed rpire closed 3 years ago

rpire commented 3 years ago

Changes made:

Added check_complete.js with the checkComplete function to mark tasks as completed using checkboxes.
Added localStorage functionalities.
Changed genHTML function to generate lined-through text when a task is completed.

rpire commented 3 years ago

Hello @ZawadiSumba66 👋

I'm not having this problem when running the webserver. As you can see it shows permission errors, but it's not keeping the browser from showing the page.

The only difference I can see between the picture adjunted to the comment and my code is the port specification in webpack.config.js I'm not sure if that is what's causing the problem.

One of my partners ran it earlier and didn't experienced this problems but I'll ask another one for another review and see if we can address the issue.

Thank you for reviewing my code. I will be waiting for further instructions on how to proceed with this review.

ZawadiSumba66 commented 3 years ago

@rpire I just removed the port: 3000, line that you had added to your code to see if the server would open without it. Unfortunately it did not. That's why you noticed that change. By the way, there is a review I missed please remove the node_modules from the root directory and add them to gitignore since it contains many unnecessary files for production.

rpire commented 3 years ago

Hello @dasileker 👋

Thank you for reviewing my work. It is running on my side, that is why it is difficult for me to address the issue but, do you think it is a bad set-up of Webpack? And if you think so, do you think it is a good idea to start fresh in a new repository for the next milestone and set up Webpack again?

Once again thank you for your review. I will do it more carefully next time. I only hope to find out why WebServer is not working for other people but it is for me.

Cheers and Happy Coding!

dasileker commented 3 years ago

Hello @dasileker 👋

Thank you for reviewing my work. It is running on my side, that is why it is difficult for me to address the issue but, do you think it is a bad set-up of Webpack? And if you think so, do you think it is a good idea to start fresh in a new repository for the next milestone and set up Webpack again?

Once again thank you for your review. I will do it more carefully next time. I only hope to find out why WebServer is not working for other people but it is for me.

Cheers and Happy Coding!

No it's not a bad setup, I think it's a npm issue you could fix by redoing it in a separate folder then add it here.