search

rpjohnst / dejavu

Game Maker reimplementation
https://dejavu.abubalay.com
Apache License 2.0
72 stars 7 forks source link

runner: Fix build and use ErrorPrinter #36

Closed elipsitz closed 4 years ago

elipsitz commented 4 years ago

Commit c822dc13 broke the 'runner' crate due to changing the API in gml::front for error handling and instruction -> source location conversion.

This commit just copies the new usage from the 'playground' crate.

'cargo build' followed by 'cargo run' works as expected, and prints the output of the built-in test script. Changing the script to produce a syntax error or runtime error (I did division by zero) prints out the correct error message with a line number.

rpjohnst commented 4 years ago

Thanks for catching this! I actually fixed this locally a few days ago and just haven't pushed yet... didn't realize anyone was watching. :)

elipsitz commented 4 years ago

I keep telling myself I'm going to actually learn Rust so I can contribute :)

rpjohnst commented 4 years ago

I do hope with the next push to have the engine and gml-meta crates in a state where people can implement GML APIs without getting blocked on infrastructure work everywhere. I guess that ought to include a README/docs/CI/etc. as well!

elipsitz commented 4 years ago

Looking forward to it! Please also consider adding a LICENSE!