rpkilby / jsonfield

A reusable Django model field for storing ad-hoc JSON data
MIT License
1.16k stars 271 forks source link

ImportError: No module named six #170

Closed RevolutionTech closed 7 years ago

RevolutionTech commented 8 years ago

six is not marked as a dependency in setup.py, but is used in fields.py.

Minor issue as generally everyone has six, but still- if one installs django-jsonfield in a fresh virtualenv, they may run into issues.

zsoldosp commented 7 years ago

Django bundles six into it under django.utils.six. It is there already in 1.4. Maybe importing that instead of six in the codebase could be an alternative

edit: checked the codebase, and it already uses the bundled version, except for Django 1.4.1 - see 3e5c9ada51b

RevolutionTech commented 7 years ago

Right, and since Django 1.4 is no longer supported this isn't really relevant anymore.