search

rpl / flow-coverage-report

Generate flow coverage reports in JSON, HTML and in the console.
MIT License
505 stars 42 forks source link

--exclude-non-flow to exclude non flow files from coverage report #144

Closed villesau closed 6 years ago

villesau commented 6 years ago

Fixes this: https://github.com/rpl/flow-coverage-report/issues/85 by introducing --exclude-non-flow flag.

Reasoning is that project might contain legacy files which will never be turned into Flow, so it does not make sense to track coverage on them. Instead, it makes sense to concentrate on flow annotated files and their quality.

Also added bunch of libdefs and flow annotated few files :)

ping @rpl

tiarebalbi commented 6 years ago

This PR looks good, right? Could we move ahead with this changes :) This option will be really useful.

Thank you.

rpl commented 6 years ago

Hi @villesau sorry for the long waiting time, and thanks a lot for contributing the changes needed to add the --exclude-non-flow cli option.

I've been looking a bit into how I would prefer to manage the updates of the new flow-typed definition included in the repo (and tried to reduce them to the minimum), and I also added a new unit test for the --exclude-non-flow cli option and so I ended up creating a new pull request with the new changes applied on top of yours.

I'm closing this PR because #154 include both this pull request and the additional changes I've been working on locally, but don't worry... I'm going to merge #154 as soon as all the tests pass on travis ;-) (at least if you confirm that #154 does also cover your use case as it is, otherwise I'm open to quickly discuss if we need to change anything on it before merging it)