search

rpl / flow-coverage-report

Generate flow coverage reports in JSON, HTML and in the console.
MIT License
505 stars 42 forks source link

fix: Upgrade production dependencies + babel and eslint #197

Closed julienw closed 4 years ago

julienw commented 4 years ago

Some dependencies have security problems so I updated all of the production ones (the ones that are important for projects using the lib).

Because the project uses an old Flow version I had to hack a bit around the flow libdefs, but that should be OK. The dependencies don't have a lot of changes, so keeping the old libdefs was easy. Only for yargs I got it from flow-typed' previous version.

Because there was an issue with eslint in travis I also went ahead and upgraded both babel and eslint. And then fixed all new eslint violations. So this makes a big patch! but with quite independent commits. I hope that will be ok :-)

Next step could be to upgrade jest, that shouldn't be too painful, and then maybe you can add depfu.com (my favorite dependency upgrader) on this repository so that it's handled some more automatically and progressively in the future.

I checked with our project and this runs and gives the same result as before the change (both text and html) in about the same time.

One test seems flaky but it seemed flaky on master too (the one about the badge)... It looks like it passes on Travis though.

julienw commented 4 years ago

Dang, the linter fails on travis but not for me locally :-/ And I have no idea: it fails on an export type XXX = YYY saying XXX is not defined. Well obviously, the line defines it...

julienw commented 4 years ago

I decided to upgrade eslint and babel and related packages. It's still failing but with another error. Let's see :)

julienw commented 4 years ago

Yay, I managed to make it green \o/

So, what do you think @rpl? Sorry for this quite big PR...

julienw commented 4 years ago

Thanks for the merge !