rpm-software-management / ci-dnf-stack

CI tests for the dnf stack
GNU General Public License v3.0
14 stars 48 forks source link

[modularity] Module defaults #340

Open mhatina opened 6 years ago

mhatina commented 6 years ago

We need ini file with defaults for testing purposes (enable module based on installing rpm).

File should look like this:

[httpd]
name=httpd
stream=2.4
profiles=default, doc

and should be saved in /etc/dnf/modules.defaults.d/ as httpd.defaults.

ignatenkobrain commented 6 years ago

So what's the problem? Create it ;)

kkaarreell commented 6 years ago

The idea was to have a dedicated step that would be referring to modules rather than using the generic step for ini files in the *.feature file. Something like

(Given) a module system profile {basename}
 | Section | Key | Value |
...

@mhatina @dmach Does the step name look acceptable or do you have different proposal?

ignatenkobrain commented 6 years ago

Why to create such weird steps? There is already one to create ini files...

dnf-docker-test/features/steps/file_steps.py:@given('an INI file "{filepath}" with')

kkaarreell commented 6 years ago

Because it would make the test scenario more readable. This is the concept of the BDT.

ignatenkobrain commented 6 years ago

In this case I don't think that it makes any time more readable...

kkaarreell commented 6 years ago

With that argument even the INI step is useless as we already have step_a_file_filepath_with.