search

rpm-software-management / createrepo_c

C implementation of the createrepo.
http://rpm-software-management.github.io/createrepo_c
GNU General Public License v2.0
100 stars 93 forks source link

Why remove the uncompressed XML files from repodata? #431

Closed PshySimon closed 5 months ago

PshySimon commented 5 months ago

I'm confused about this commit, https://github.com/rpm-software-management/createrepo_c/pull/373/commits/22eb96fd66dab0a8756a65919ea98272b4d1c49b, which remove uncompressed XML files from repodata. I want to know what specific impact does this operation have?

Btw, I noticed in the changelog that there is mention of incompatibility with yum, specifically, where exactly is the incompatibility located?

ppisar commented 5 months ago

My understanding: The way how some files were compressed diverged over the time. Some were compressed, some kept uncompressed. I believe that commit was an attempt to unify the compression. One of the reasons why some files were kept uncompressed were bugs in old yum versions which forgot to support a compression on that files. That's the incompatibility.

More details could provide you an author of that commit.

ppisar commented 5 months ago

If you are fine with the answer, I will close this issue.

dralley commented 5 months ago

That answer is essentially correct. If you need to use a new very version of createrepo_c with an old distribution thta uses yum, please use the --compatibility flag.