search

rpm-software-management / dnf-plugins-extras

repository for DNF community plugins
GNU General Public License v2.0
65 stars 62 forks source link

Reset all modules except enabled and with defaults (RhBug:1811234) #178

Closed kontura closed 1 year ago

kontura commented 4 years ago

Downstream hack only

During system-upgrade to F31 or F32 (F >= 33 don't have defaults) reset modules to resolve missing upgrade path only if they don't have default stream or are not enabled.

The module reset is not applied to offline-distrosync and offline-upgrade commands.

Also fixes a fix from RhBug:1767351 where we ran the same module reset during run_upgrade which was needed becase the new state from run_download wasn't saved to the module persistor.

https://bugzilla.redhat.com/show_bug.cgi?id=1767351 https://bugzilla.redhat.com/show_bug.cgi?id=1811234

kontura commented 4 years ago

I have also substituted the _setup_modular_excludes() call with the functions implementation but I switched the parameter update_only to True for the call of filter_modules(...). I believe update_only=True is sufficient because we don't need to rebuild the whole ModulePackageContianer.

j-mracek commented 4 years ago

I have also substituted the _setup_modular_excludes() call with the functions implementation but I switched the parameter update_only to True for the call of filter_modules(...). I believe update_only=True is sufficient because we don't need to rebuild the whole ModulePackageContianer.

The perfect suggestion :+1:

j-mracek commented 4 years ago

LGTM!

kontura commented 4 years ago

Rebased.

j-mracek commented 4 years ago

The patch is inly for the Fedora downstream.

rh-atomic-bot commented 3 years ago

:umbrella: The latest upstream changes (presumably 609abb3) made this pull request unmergeable. Please resolve the merge conflicts.