dnf5daemon: before_begin / after_complete signals not added to introsepction

rpm-software-management / dnf5

Next-generation RPM package management system

Other

256 stars 87 forks source link

dnf5daemon: before_begin / after_complete signals not added to introsepction #1463

Open timlau opened 6 months ago

timlau commented 6 months ago

new signals added in

https://github.com/rpm-software-management/dnf5/commit/7ea691974b689070472d4e12b4d9dfc5df7ad240

is not added to dbus introspection

They should be registered here, like other DBUS signals.

https://github.com/rpm-software-management/dnf5/blob/d1c1cebbcb6f5786477492378d1e7628f9c64608/dnf5daemon-server/services/rpm/rpm.cpp#L117

The problem is that some DBUS libraries like DASBus check the introspection before connecting to a signal and if it is not there you can't connect to the signal.

m-blaha commented 6 months ago

Hi, the signals should be there, see https://github.com/rpm-software-management/dnf5/blob/269ce5c6b25d5e4822327d2862f5213649be4cc2/dnf5daemon-server/dbus/interfaces/org.rpm.dnf.v0.rpm.Rpm.xml#L231-L253

timlau commented 6 months ago

Tested using the nightly build of 5.2, can see that the signals is available, so every thing looks good.

In 5.1.x the registerSignal was needed to make the signals visible, so this code is properly not needed any more, if the introspection is working in 5.2, using the .xml file, must be some other change i have missed

https://github.com/rpm-software-management/dnf5/blob/d1c1cebbcb6f5786477492378d1e7628f9c64608/dnf5daemon-server/services/rpm/rpm.cpp#L117