search

rpm-software-management / dnf5

Next-generation RPM package management system
Other
240 stars 76 forks source link

system-upgrade download provides confusing output and stuck at some point #1667

Open j-mracek opened 1 week ago

j-mracek commented 1 week ago

dnf5 system-upgrade download --releasever 40 ended with following outputs

[2687/2687] Total                                                                                                                                     100% |  20.2 MiB/s |   3.2 GiB |  02m40s
Testing offline transaction
Warning: skipped PGP checks for 2687 packages from repository: @stored_transaction
Transaction stored to be performed offline. Run `dnf5 offline reboot` to reboot and run the transaction. To cancel the transaction and delete the downloaded files, use `dnf5 offline clean`.
Complete!

After line [2687/2687] Total it requires 3m 40s probably to generate file with description of transaction. Then it reports Testing offline transaction. We could discuss whether 10 or 20 seconds is a limit for user where to start to think what is going on, but after nearly 4 minute many user will interrupt. I recommend to improve performance and create a bar with progress.

The next line is problematic: Warning: skipped PGP checks for 2687 packages from repository: @stored_transaction How I can trust the transaction? It mentions repository that is not in transaction and it anyway does not check PGP keys. It scares me a lot.

jan-kolarik commented 1 week ago

Hi Jarda, thanks for the info!

We could discuss whether 10 or 20 seconds is a limit for user where to start to think what is going on, but nearly 4 minute many user will interrupt. I recommend to improve performance and create a bar with progress.

I completely agree. We should regularly update users on the progress to ensure they know that something is happening.

The next line is problematic: Warning: skipped PGP checks for 2687 packages from repository: @stored_transaction How I can trust the transaction? It mentions repository that is not in transaction and it anyway does not check PGP keys. It scares me a lot.

We've already received a similar report and created an issue for it: https://github.com/rpm-software-management/dnf5/issues/1668. Let's focus just on the progress report in this issue.