search

rpm-software-management / libdnf

Package management library.
GNU Lesser General Public License v2.1
184 stars 139 forks source link

[dnf5] excessive rpm debug logging by default #1528

Open dmach opened 2 years ago

dmach commented 2 years ago

DNF 5 prints rpm's ufdio read stats, which are quite unexpected. Please note I'm running openSUSE Tumbleweed, rpm-4.17.0-7.4.x86_64

$ dnf5 reinstall vim
Updating and loading repositories:
Repositories loaded.

Package                 Arch   Version                 Repository           Size
Reinstalling:                                                                   
 vim                    x86_64 8.2.4877-1.4            download.opensu   4.4 MiB
   replacing vim        x86_64 8.2.4877-1.4            <TODO: from_rep   4.4 MiB

Transaction Summary:
 Reinstalling:      1 packages
 Replacing:         1 packages

Is this ok [y/N]: y
Downloading Packages:
[1/1] vim-0:8.2.4877-1.4.x86_64         100% |   0.0   B/s |   0.0   B |  00m00s
>>> Already downloaded

--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
[1/1] Total                             100% |   0.0   B/s |   0.0   B |  00m00s

Running transaction
ufdio:       6 reads,   362993 total bytes in 0.000056 secs
ufdio:      72 reads,  2461588 total bytes in 0.000425 secs
ufdio:       2 reads,      144 total bytes in 0.000005 secs
ufdio:      18 reads,  4440704 total bytes in 0.000529 secs
ufdio:       2 reads,     2120 total bytes in 0.000005 secs
ufdio:       2 reads,    14464 total bytes in 0.000006 secs
ufdio:       2 reads,    18696 total bytes in 0.000007 secs
...
lukash commented 2 years ago

Are you saying you're not interested in the detailed ufdio stats? :nerd_face:

Sorry about the inconvenience, fixed in rpm: https://github.com/rpm-software-management/rpm/issues/1987

It appears the fix will be released in rpm-4.18.0 which may be a ways off.

But I think this could be alleviated via implementing log mask in dnf 5 logger and forwarding it to rpm. We should turn debug level logging off by default anyway.