search

rpm-software-management / libdnf

Package management library.
GNU Lesser General Public License v2.1
184 stars 139 forks source link

Add virtual destructor to TransactionItem #1648

Closed inknos closed 7 months ago

jan-kolarik commented 7 months ago

As users can access the TransactionItem via upcast, I think we also need to add it to the TransactionItemBase.

inknos commented 7 months ago

As users can access the TransactionItem via upcast, I think we also need to add it to the TransactionItemBase.

I am getting a bit lost in the virtual c++ terms, but I guess providing only these two lines is now sufficient for upcasting.