Return "calculated" checksum if requested w/caching

rpm-software-management / librepo

A library providing C and Python (libcURL like) API for downloading packages and linux repository metadata in rpm-md format

http://rpm-software-management.github.io/librepo/

GNU Lesser General Public License v2.1

74 stars 91 forks source link

Return "calculated" checksum if requested w/caching #234

Closed malmond77 closed 3 years ago

malmond77 commented 3 years ago

If a file is downloaded via librepo (e.g. dnf install --downloadonly) then a request to get the checksum via lr_checksum_fd_compare() will not work. It'll only return whether the checksum is valid, and not the actual checksum. This is the simple fix.

Addresses #233

m-blaha commented 3 years ago

Please, can you also bump the Version: field in librepo.spec to be in sync with VERSION.cmake? We are using this spec file to build our nightlies. Other then this the PR is ready to be merged. Thanks for your work!

m-blaha commented 3 years ago

Thanks! I'll wait for tests to finish and merge it.