Closed kontura closed 3 years ago
Wow... very hard to review the last commit. I could do it locally, but what about removing the last commit from this PR and creating a special PR for it? That way if there are only the fail_if
-> asserts changes and they all pass, we have reasonable certainty the change is correct (for binary checks we can be certain, for e.g. range checks not so much, but those aren't too many).
Wow... very hard to review the last commit. I could do it locally, but what about removing the last commit from this PR and creating a special PR for it? That way if there are only the
fail_if
-> asserts changes and they all pass, we have reasonable certainty the change is correct (for binary checks we can be certain, for e.g. range checks not so much, but those aren't too many).
ok, I have removed the last commit from here and will make a separate PR once this is merged (since I am adding few fail_if
's here).
Replacing all the
fail_if
's makes this quite big and I would say hard to review since we are going fromfail_if
toassert
so negation of the conditions is usually needed.For: https://bugzilla.redhat.com/show_bug.cgi?id=1938782