search

rpm-software-management / librepo

A library providing C and Python (libcURL like) API for downloading packages and linux repository metadata in rpm-md format
http://rpm-software-management.github.io/librepo/
GNU Lesser General Public License v2.1
74 stars 90 forks source link

Run integration tests for both dnf4 and dnf5 #272

Closed kontura closed 1 year ago

kontura commented 1 year ago

Librepo is simultaneously used in both stacks therefore we should test both of them.

This fixes an issue where we currently use dnf5 ci-dnf-stack branch but run dnf4 tests which fails because of missing dependencies (swidtags).

kontura commented 1 year ago

Requires: https://github.com/rpm-software-management/ci-dnf-stack/pull/1219

The current CI is failing because it is still running with the old config, with the new configuration it will look like: https://github.com/kontura/librepo/pull/1

kontura commented 1 year ago

I believe rerunning the CI won't help here because it will still use the configuration from the current code not from the PR. It will continue to run dnf5 main branch but with dnf4.

You can check the PR I linked where my master already has this commit and because of that it ran both dnf4 and dnf5 CI correctly.

jan-kolarik commented 1 year ago

Oh I see, I didn't analyze the content of this PR yet and assumed that the requirement from ci-dnf-stack is enough :slightly_smiling_face:

jan-kolarik commented 1 year ago

LGTM, thanks!