search

rpm-software-management / mock

Mock is a tool for a reproducible build of RPM packages.
GNU General Public License v2.0
376 stars 220 forks source link

Fix broken attempt to handle --install completion #1321

Closed opoplawski closed 4 months ago

opoplawski commented 4 months ago

Attempt at fixing #1279

Very sorry about the mess, hopefully this fixes it. Are there other greedy options that can take more than one arguement that we need to worry about?

praiskup commented 4 months ago

I submitted PR #1320 a few hours earlier; do you think this one is better?

praiskup commented 4 months ago

Are there other greedy options that can take more than one arguement that we need to worry about?

I think there are a few of them. See #1320.

There's also a fix for: mock --install x86_64/foo-20240214_1237-1.fc39.x86_64.rpm -r fedora-rawhide-x86_64 x86_64/<tab>

praiskup commented 4 months ago

And the implicit --rebuild mode.

praiskup commented 4 months ago

Closing, but thank you for the PR.