search

rpm-software-management / mock

Mock is a tool for a reproducible build of RPM packages.
GNU General Public License v2.0
381 stars 227 forks source link

Fix root_cache invalidation triggered by config changes #1322

Closed praiskup closed 7 months ago

praiskup commented 7 months ago

The root_cache plugin assures that no new configuration file in the config_opts['config_paths'] list is newer than the root_cache cache tarball, otherwise the caches are invalidated.

The bug is caused by use of improper set operation (union() doesn't modify the calling object).

pep8speaks commented 7 months ago

Hello @praiskup! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! :beers:

Comment last updated at 2024-02-14 10:59:44 UTC
hroncok commented 7 months ago

Does this invalidate the bootstrap chroot as well? I recall I needed to drop it when rawhide was updated to dnf5.