search

rpm-software-management / mock

Mock is a tool for a reproducible build of RPM packages.
GNU General Public License v2.0
376 stars 219 forks source link

Add composed c10s repos #1383

Closed hroncok closed 2 weeks ago

hroncok commented 3 weeks ago

Fixes https://github.com/rpm-software-management/mock/issues/1372

Depends on: https://github.com/xsuchy/distribution-gpg-keys/pull/119

hroncok commented 3 weeks ago

I have tested this together with https://github.com/xsuchy/distribution-gpg-keys/pull/119 and it works.

praiskup commented 3 weeks ago

Can you please bump the distribution-gpg-keys requirement to 1.104 and provide the towncrier snippet?

praiskup commented 3 weeks ago

Per this CI log:


Please provide release notes snippet, per the instructions
https://rpm-software-management.github.io/mock/Release-Notes-New-Entry
hroncok commented 3 weeks ago

I can do that later. Or you can amend my PR (I'm OK with that), if you want to merge sooner.

davide125 commented 2 weeks ago

This needs to be reworked to point to the mirrors instead of composes now that we have c10s published on the mirrors. It also needs an additional stanza for Extras (which provides SIG release packages), similar to the one we have in the c9s template.

hroncok commented 2 weeks ago

This needs to be reworked to point to the mirrors instead of composes now that we have c10s published on the mirrors.

Not even the c10s centos-stream-release package has that yet.

https://gitlab.com/redhat/centos-stream/rpms/centos-release/-/blob/c10s/centos.repo?ref_type=heads

It also needs an additional stanza for Extras (which provides SIG release packages), similar to the one we have in the c9s template.

Where do I find the repo URLs?

I disagree this needs to be done. We can have gradual improvements. This has been tested and works.

Once the centos-stream-release package is updated with mirrored repos, we can do the same.

@praiskup changelog added, gpg-keys requirement bumped

davide125 commented 2 weeks ago

It also needs an additional stanza for Extras (which provides SIG release packages), similar to the one we have in the c9s template.

Where do I find the repo URLs?

https://mirror.stream.centos.org/SIGs/10-stream/extras/x86_64/extras-common/

I disagree this needs to be done. We can have gradual improvements. This has been tested and works.

Once the centos-stream-release package is updated with mirrored repos, we can do the same.

Totally agree, incremental improvements are the way to go. Re-reading my comment it came out stronger than I meant, sorry about that.

praiskup commented 2 weeks ago

Sorry for the changelog-change CI failure; the file clearly is there, but the changed-files addon doesn't detect it.

praiskup commented 2 weeks ago

I'm for merging the current state. @hroncok @Conan-Kudo @davide125 wdyt?

praiskup commented 2 weeks ago 

PASSED: centos-stream-10-x86_64.cfg (tmpfs)
PASSED: centos-stream-10-x86_64.cfg
PASSED: centos-stream-8-x86_64.cfg (tmpfs)
PASSED: centos-stream-8-x86_64.cfg
PASSED: centos-stream-9-x86_64.cfg (tmpfs)
PASSED: centos-stream-9-x86_64.cfg
hroncok commented 2 weeks ago

Not all repos were converted to metalinks. See https://github.com/rpm-software-management/mock/pull/1390