Closed hroncok closed 2 years ago
If there are no issues with the CI here, I will open a Fedora PR as well, so we can run the CI there as well.
Note for self:
A real package with this thing issue build[virtualenv] 0.8.0,
A real package with this issue is build[virtualenv] 0.8.0,
Note for self:
A real package with this thing issue build[virtualenv] 0.8.0,
A real package with this issue is build[virtualenv] 0.8.0,
Amended.
The idea is that the extra subpackage only has requirements specific to that extra. The logic however only excluded requirements without markers, but requirements with a marker that was correct leaked to all extras subpackages.
E.g. with the following requirements:
On Python 3.10, the base package generated the following requirements:
And for the [an-extra] extra:
Now we no longer just check if the marker evaluates to True, but we also check that the same marker evaluates to False when the extra is not given.
A real package with this thing issue build[virtualenv] 0.8.0, which we use for tests. The package has:
And on Python 3.10, it generated the following dependency for python3-build+virtualenv-0.8.0-2.fc37.noarch.rpm:
Now it no longer does. This is asserted in tests.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2090186