search

rpm-software-management / spec-cleaner

spec-cleaner
BSD 3-Clause "New" or "Revised" License
28 stars 34 forks source link

_find_macros_with_arg in rpmregexp does nothing #131

Closed scarabeusiv closed 8 years ago

scarabeusiv commented 8 years ago

https://github.com/openSUSE/spec-cleaner/blob/master/spec_cleaner/rpmregexp.py#L200

I am not sure what it was supposed to do but no test in the testsuite hit the condition. Could you please figure it out as it is your code?

sleep-walker commented 8 years ago

This code should detect local macros with arguments

%define some_useful_macro(... \
                          ...)

I'm not sure if it is relevant but it looks like the intention was to exclude found macro functions from putting braces around (because they can be multiline?)...

scarabeusiv commented 8 years ago

As I told on irc, if it works then it is nice, but we should have at least one testcase actually checking for the functionality please.

scarabeusiv commented 8 years ago

Found the culprit and fixed :)