Type checking and small fixes

rpm-software-management / spec-cleaner

spec-cleaner

BSD 3-Clause "New" or "Revised" License

28 stars 34 forks source link

Type checking and small fixes #248

Closed kstreitova closed 5 years ago

kstreitova commented 5 years ago

Use type hints for the most important parts of the code (issue #243). The rest of the code will be covered later.

Also, fix a few various small issues I bumped into during the type hints implementation.

coveralls commented 5 years ago

Coverage increased (+0.06%) to 94.441% when pulling 848b8bcb703f840f5b7943601320d712154d00d2 on kstreitova:type_checking into 5e4807cc56b02fffedd19a208685be49afc291fc on openSUSE:master.

coveralls commented 5 years ago

Coverage increased (+0.04%) to 94.419% when pulling 8481a62eb4d509fee10c3889e780c1770f7e9cab on kstreitova:type_checking into 5e4807cc56b02fffedd19a208685be49afc291fc on openSUSE:master.

scarabeusiv commented 5 years ago

Overall the changes look sane, now for the typing it should be added to setup.py as a dependency and also we should maybe even adjust tox.ini to execute the mypy check?