search

rpm-software-management / spec-cleaner

spec-cleaner
BSD 3-Clause "New" or "Revised" License
28 stars 34 forks source link

Change libexecdir substitution to do /usr/libexec to %{_libexecdir} #262

Closed Conan-Kudo closed 4 years ago

Conan-Kudo commented 4 years ago

As %_libexecdir is now defined as /usr/libexec on Fedora, Mageia, and will be on openSUSE shortly, there's no reason for the option to not convert it, as the path is consistent. Thus, the flag has been removed from the CLI to enable the behavior and it is always on now.

mlschroe commented 4 years ago

Why will it be in openSUSE shortly?

Conan-Kudo commented 4 years ago

@mlschroe well, presumably you will eventually accept my SR that changes the definition in the openSUSE rpm package...

scarabeusiv commented 4 years ago

Just for the record as spec-cleaner is used on released products this can be merged at a point where _libexec dir points there to proper location there. Think Leap 16...

Conan-Kudo commented 4 years ago

@scarabeusiv Not true. All this does is make the match rule go from /usr/lib -> %_lilbexecdir to /usr/libexec -> %_libexecdir. That would be valid no matter what. Legacy products would just have %_libexecdir defined differently anyway. Prior to this, the rule wasn't even on by default...

scarabeusiv commented 4 years ago

Actually good point as it is using the /libexec then it should not break backwards compatibility and on contrary make TW packages building on older codestreams because it would smartly put it back to /usr/lib :)

Conan-Kudo commented 4 years ago

@scarabeusiv Can you please make a new release and push it into Factory? I want this to land ASAP along with the RPM 4.15 stuff.