Add %{dephell_gensetup} macro instead of the full call to dephell command

rpm-software-management / spec-cleaner

spec-cleaner

BSD 3-Clause "New" or "Revised" License

28 stars 34 forks source link

Add %{dephell_gensetup} macro instead of the full call to dephell command #276

Closed mcepl closed 4 years ago

mcepl commented 4 years ago

Failing tests are because of the difference between %{dephell_gensetup} and %dephell_gensetup. Not sure which one I should include.

scarabeusiv commented 4 years ago

Failing tests are because of the difference between %{dephell_gensetup} and %dephell_gensetup. Not sure which one I should include.

Well as i said in the review it should be without, but you are lacking the %changelog in the outputs. Also you should maybe also test conversion of other permutations of this command we have in factory. And last but not least decide wether this replacement really should be done in minimal mode or not, i would say it should not touch anything in minimal.