search

rpm-software-management / spec-cleaner

spec-cleaner
BSD 3-Clause "New" or "Revised" License
28 stars 34 forks source link

Add new script for rpmlint. #286

Closed marxin closed 3 years ago

marxin commented 3 years ago

The script is used to generate licenses.toml configuration file consumed by rpmlint.

scarabeusiv commented 3 years ago

Makefile should generate the file like the licenses list then.

Also why don't you use fstrings f'{variable}'?

marxin commented 3 years ago

Makefile should generate the file like the licenses list then.

Added.

Also why don't you use fstrings f'{variable}'?

I'm not familiar with that, but I'll learn it. I promise! And I changed that in the pull request.

scarabeusiv commented 3 years ago

You don't have to gitignore the file i would say, we can keep it in the scm and regenerate it on releases. Then you can fetch it from releases/git here and not rely on it anywhere else?

scarabeusiv commented 3 years ago

All the conversion tables afterall are generated and we keep them stored.

scarabeusiv commented 3 years ago

Also what the ... is again with coveralls, i start to hate that package, every 3 months different approach on how to add the stuff...

marxin commented 3 years ago

All the conversion tables afterall are generated and we keep them stored.

Done that.

marxin commented 3 years ago

I also removed the strange First line from data/licenses_changes.txt file.