rpm-software-management / spec-cleaner

spec-cleaner
BSD 3-Clause "New" or "Revised" License
27 stars 33 forks source link

Wrong replacement BuildArch to ExclusiveArch #289

Closed mimi1vx closed 1 year ago

mimi1vx commented 3 years ago
ExclusiveArch:  i586 i686
BuildArch:      i686
%{expand:%%global optflags %(echo "%{optflags}"|sed -e s/i586/i686/) -march=i686 -mtune=generic}
%endif

is transformed by spec-cleaner to:

%ifarch %{ix86}
ExclusiveArch:  i586 i686
ExclusiveArch:  i686
%{expand:%%global optflags %(echo "%{optflags}"|sed -e s/i586/i686/) -march=i686 -mtune=generic}
%endif
kstreitova commented 1 year ago

Actually, it's not wrong. The only allowed value of BuildArch is "noarch", so the spec-cleaner automatically transforms any BuildArch with no "noarch" to ExclusiveArch as this is probably what the writer wanted to do.

kstreitova commented 1 year ago

Talked to @mimi1vx and we decided that we can close this issue as invalid.