I combined some elements from the Fedora spec with ours. The result is pure mess after spec-cleaner went over it.
From top to bottom: it removed an important comment for no good reason. Let's call it 3rd comment section. Sure, I can imagine, that it's hard to safely replace/update the copyright header, but you never should remove any auxiliary comments. By the way, I started with adding the somewhat prefered pattern in Fedora of:
only to find them vanished. After reading the source, I came up with the %if/%endif clause to protect this, and I put this in front of the now eliminated 3rd comment section originally.
The %{?_with_ clauses where intermingled in the rest of the BuildRequires of course.
Given, spec-cleaning nowadays is mandatory in working with osc, it should be save to use in all cases, but it's not:
Check out this beauty: https://build.opensuse.org/package/rdiff/home:frispete:test/freerdp?opackage=freerdp&oproject=openSUSE%3AFactory&rev=3
I combined some elements from the Fedora spec with ours. The result is pure mess after spec-cleaner went over it.
From top to bottom: it removed an important comment for no good reason. Let's call it 3rd comment section. Sure, I can imagine, that it's hard to safely replace/update the copyright header, but you never should remove any auxiliary comments. By the way, I started with adding the somewhat prefered pattern in Fedora of:
only to find them vanished. After reading the source, I came up with the
%if
/%endif
clause to protect this, and I put this in front of the now eliminated 3rd comment section originally.The
%{?_with_
clauses where intermingled in the rest of the BuildRequires of course.Last, but not least, these lines:
were inside
before.
Given, spec-cleaner is mandatory in the obs build process, this isn't going to fly, to put it kindly.