move logic that tries to change the URL field to https into _make_secure_url

rpm-software-management / spec-cleaner

spec-cleaner

BSD 3-Clause "New" or "Revised" License

27 stars 33 forks source link

move logic that tries to change the URL field to https into _make_secure_url #300

Closed jsegitz closed 1 year ago

jsegitz commented 2 years ago

Use it for source entries to change URLs there too. Add support for ftp URLs on servers that have the same directory structure available via https

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging fa61bbc6172cce76b2dc2154484011c17fc58578 into 52b6687765189041a6b1f69f272364f12e4a22be - view on LGTM.com

new alerts:

1 for Unnecessary pass
1 for Unused local variable

jsegitz commented 2 years ago

I'll fix the test issues/the tests itself

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 65652cd90169a1259ca6b9f21a5eb52ea05e339c into 52b6687765189041a6b1f69f272364f12e4a22be - view on LGTM.com

new alerts:

1 for Unnecessary pass
1 for Unused local variable

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 10d832da65fa8f06d30742e2054ab2bc687baa3c into 52b6687765189041a6b1f69f272364f12e4a22be - view on LGTM.com

new alerts:

1 for Unnecessary pass
1 for Unused local variable

jsegitz commented 2 years ago

Local tests work fine. This is the result that isort gives me for this file. Not sure why it's not happy with it

lgtm-com[bot] commented 2 years ago

This pull request introduces 2 alerts when merging 1a41e0b223fa99f021a988afa45f846c31b734e4 into 52b6687765189041a6b1f69f272364f12e4a22be - view on LGTM.com

new alerts:

1 for Unnecessary pass
1 for Unused local variable