rpm-software-management / spec-cleaner

spec-cleaner
BSD 3-Clause "New" or "Revised" License
27 stars 33 forks source link

Add missing groups from openSUSE:Package_group_guidelines #318

Closed marcosbc closed 8 months ago

marcosbc commented 8 months ago

The list of allowed package groups is outdated with respect to openSUSE:Package_group_guidelines, so I sent this PR updating them.

NOTE: To generate the changes in this PR, I executed the following commands:

cd spec-cleaner/data
echo '# Taken from https://en.opensuse.org/openSUSE:Package_group_guidelines' > allowed_groups.txt
curl -s https://en.opensuse.org/openSUSE:Package_group_guidelines | grep -Eo '^[^ ]+<tt>.*</tt>' | sed -E -e 's/^[^ ]+<tt>//g' -e 's/<\/tt>.*//g' >> allowed_groups.txt

Fixes #317

marcosbc commented 8 months ago

Hi @mcepl, the default configuration for Open Build Service currently warns if this section is missing, are you sure that it is obsolete? For instance:

hello-world.src: W: non-standard-group Unspecified
hello-world.x86_64: W: non-standard-group Unspecified
The value of the Group tag in the package is not valid.  Valid groups are:
"Amusements/Games/3D/Other", "Amusements/Games/3D/Race",
(...)
"System/X11/Terminals", "System/X11/Utilities", "System/YaST".

2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Here can you find an example of such errors (go to the "RPM Lint" section to see the warnings).

mcepl commented 8 months ago

On Fri Nov 17, 2023 at 1:09 PM CET, Marcos Bjoerkelund wrote:

Hi @mcepl, the default configuration for Open Build Service currently warns if this section is missing, are you sure that it is obsolete? For instance:

Which distro? I don’t see anything like that for Tumbleweed or reasoably recent (and supported) SLE/Leap distros.

Matěj

-- http://matej.ceplovi.cz/blog/, @@.*** GPG Finger: 3C76 A027 CA45 AD70 98B5 BC1D 7920 5802 880B C9D8

Revenge is the misguided attempt to transform shame and pain into pride. -- Oceanbreeze7 in the summary of the story “Antithesis” (on FFN)

marcosbc commented 8 months ago

@mcepl Please have a look at this project in OBS I created as an example for this issue: home:mbjoerkelund:spec-cleaner-318/hello-world

I updated the project to build for SLE, openSUSE Leap and Tumbleweed. You can see that the RPMlint warning appears both for SLE and openSUSE Leap, but not for Tumbleweed, so I think this is still applicable.

mcepl commented 8 months ago

Then ask for the upgrade of rpmlint in SLE/Leap, but I will do nothing to support the idea of groups.

marcosbc commented 8 months ago

It seems like the Group: tag is still required for SLE and Leap, but this change has been rejected altogether, so I'm going to close this MR.